Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Detection Engine health API #643

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Add Detection Engine health API #643

merged 1 commit into from
Jul 12, 2023

Conversation

banderror
Copy link
Contributor

Epic: elastic/kibana#125642

Summary

This PR adds the Detection Engine health API implemented in elastic/kibana#157155, to the list of supported endpoints. There was also some cleanup done.

  • /internal/detection_engine/health/_cluster endpoint is added as kibana_detection_engine_health_cluster
  • /internal/detection_engine/health/_space endpoint is added as kibana_detection_engine_health_space
  • kibana_detection_engine_find renamed to kibana_detection_engine_rules_installed
  • kibana_detection_engine_signals renamed to kibana_detection_engine_rules_prebuilt_status
  • Added comments, sorted the entries

Checklist

  • I have verified that the APIs in this pull request do not return sensitive data

@banderror banderror mentioned this pull request Jun 23, 2023
Open
11 tasks
111andre111
111andre111 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@111andre111 111andre111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added some comments but in general looks good to me.

@banderror
Copy link
Contributor Author

@111andre111 Could you please merge the PR? Either I don't have privileges or it requires additional approval from someone else:

Screenshot 2023-07-05 at 21 00 02

@pickypg pickypg merged commit 09be89f into elastic:main Jul 12, 2023
@banderror banderror deleted the add-detection-engine-health-api branch July 13, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickypg pickypg pickypg approved these changes

@111andre111 111andre111 111andre111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@banderror @pickypg @111andre111